@remotion/studio: Add keyframe navigation controls to timeline field rows#7845
Merged
Merged
Conversation
…d rows Implement previous/next keyframe seeking and keyframe toggling for selected sequence controls and effect props, backed by new add-keyframe API routes. Fixes #7776 Co-authored-by: Cursor <cursoragent@cursor.com>
…pensation Position the prev/diamond/next controls before the row padding and offset the following chrome so selecting a field row does not shift its label. Co-authored-by: Cursor <cursoragent@cursor.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed changes — Add prev/diamond/next keyframe navigation controls to timeline field rows, plus backend routes and optimistic UI updates for adding sequence and effect keyframes.
/api/add-sequence-keyframeand/api/add-effect-keyframeroutes — mirror existing delete handlers, usewithSavePropsLock, push undo stack entries, suppress HMR, and return refreshed prop statusoptimisticAddSequenceKeyframeandoptimisticAddEffectKeyframe— symmetric to existing delete optimistic helpers, correctly convert static props to keyframed, append keyframes while preserving easing invariants, and update existing keyframe values in placeTimelineKeyframeControls— mounted only on selected rows, usesgetPreviousKeyframeDisplayFrame/getNextKeyframeDisplayFramefor navigation, diamond toggle switches between add and delete viahasKeyframeAtSourceFrame, respectsclientIdandcanToggleKeyframeguardsTimelineRowChrome— negative margin compensation keeps the label column stable when controls mount/unmount on selection- Tests cover navigation helpers and optimistic add logic for both sequences and effects
Kimi K2 ｜ 𝕏
JonnyBurger
changed the title
@remotion/studio: Add keyframe navigation controls to timeline field rows
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.