@remotion/studio: Show keyframe controls for keyframed props#7857
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed changes — a small, focused change that shows timeline keyframe navigation controls (left / diamond / right) for keyframed props even when the field row is not selected, applied consistently across both sequence and effect field rows.
- Extract shared visibility guard —
shouldShowTimelineKeyframeControlscentralizes the logic for when keyframe controls appear, replacing inline ternaries in bothTimelineSequenceFieldRowandTimelineEffectFieldRow. - Preserve
SELECTION_ENABLEDgating — the helper correctly respects the feature-flag so the new behavior only surfaces when timeline selection is enabled.
Kimi K2 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyframed, even if the row is not selectedFixes #7848