@remotion/studio: Add Shift/Cmd timeline multi-select#7859
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Reviewed changes — modifier-aware multi-select interactions (Shift+click range, Cmd/Ctrl+click toggle) for timeline rows and keyframes, plus registration of visible items to establish selection order.
- Add
TimelineSelectionInteractionandTimelineSelectionStatetypes — model modifier keys and anchor/selection state. - Implement
getTimelineSelectionAfterInteraction— pure selection-state reducer handling range select, toggle, and plain-click fallback with type-constrained semantics. - Add
registerSelectableItemtoTimelineSelectionProvider— tracks visible items in mount order via refs for range-selection ordering. - Wire modifier keys through pointer handlers —
TimelineKeyframeDiamond,TimelineRowChrome, andTimelineSequencenow passshiftKey/metaKey/ctrlKeyinto selection logic. - Add unit tests — cover toggle and range selection for rows, plus mixed-type anchor fallback.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
packages/studio/src/components/Timeline/TimelineRowChrome.tsx:94(RIGHT) — line 94 (RIGHT) is not inside a diff hunk
Kimi K2 | 𝕏
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Notes
Closes #7800