@remotion/studio: Add UV effect handles#7875
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Added draggable canvas handles for effect uv-coordinate props in the Studio's selected outline overlay, with bilinear interpolation for position mapping and Newton-Raphson iteration for inverse UV solving.
SelectedOutlineOverlay.tsx— AddedUvCoordinatetypes,getUvHandlePosition/getUvCoordinateForPointmath helpers,getSelectedEffectFieldsBySequenceKeyselection tracking,getSelectedUvHandleshandle generation, andSelectedUvHandleCircledrag interaction component. UV handles render alongside outline polygons for selected effects.timeline-selection.test.ts— Added round-trip tests verifying forward UV→point and inverse point→UV coordinate mapping.
Kimi K2 | 𝕏
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7786.
Summary
Testing
cd packages/studio && bun test src/test/timeline-selection.test.tsbunx turbo run make --filter='@remotion/studio'cd packages/studio && bun run lint --quietbun run build && bun run stylecheck