CLI: Parse isla's section part#91
Open
febyeji wants to merge 1 commit into
Open
Conversation
febyeji
force-pushed
the
feature/x86-tso-extraction
branch
from
ff707fa to
03b3e55
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
a94aff3 to
ae44510
Compare
febyeji
force-pushed
the
feature/x86-tso-extraction
branch
from
03b3e55 to
250237b
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
ae44510 to
a875bc3
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
a875bc3 to
daa2d91
Compare
febyeji
force-pushed
the
feature/isla-section
branch
2 times, most recently
from
ba66dd5 to
06b5be2
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
06b5be2 to
1529e83
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
from
cb2163b to
a4869ad
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
from
a4869ad to
d3b7fd0
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
1529e83 to
951abfd
Compare
Collaborator
|
Please add one arm seq test and one arm um test using this feature |
febyeji
added a commit
that referenced
this pull request
Apr 29, 2026
Adds two end-to-end tests that load fixed-address code via [section.*] and reach it from thread code: - arm/seq/EOR+section.litmus.toml: 1 thread, B-jumps to a section that performs EOR, then B-returns to the natural termination PC - arm/um/MP+section-call.litmus.toml: 2 threads (MP pattern), thread.1 detours through a section to do its second LDR before terminating Both tests pass on seq, ump, and vmp models. Pattern uses unconditional B (BL/RET are not in sail-tiny-arm's user-mode encoding set), so the section feature is exercised without depending on [thread.N.reset] or function-eval which live on parallel/downstream branches. Addresses tperami's review on #91.
febyeji
force-pushed
the
feature/isla-section
branch
from
22d4769 to
98654cb
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
from
d3b7fd0 to
acce1a4
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
98654cb to
57f4f00
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
from
acce1a4 to
7c90ade
Compare
febyeji
force-pushed
the
feature/isla-section
branch
2 times, most recently
from
d3e0249 to
bccbb84
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
2 times, most recently
from
8ac5cbf to
eb03070
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
bccbb84 to
219b09a
Compare
tperami
approved these changes
May 6, 2026
Collaborator
tperami
left a comment
tperami
left a comment
There was a problem hiding this comment.
This is good, thanks, waiting for the previous PR
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
2 times, most recently
from
592370a to
9277e33
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
219b09a to
006b33b
Compare
febyeji
force-pushed
the
feature/assembler-elf-pipeline
branch
from
9277e33 to
e24dfbf
Compare
febyeji
force-pushed
the
feature/isla-section
branch
from
006b33b to
2ae3039
Compare
tperami
approved these changes
May 12, 2026
Collaborator
tperami
left a comment
tperami
left a comment
There was a problem hiding this comment.
Just a few nits, but otherwise LGTM
| l | ||
|
|
||
| let parse_section (name, table) = | ||
| let _ = Toml.get_table table in |
Collaborator
There was a problem hiding this comment.
You don't need that anymore
| """ | ||
|
|
||
| [section.helper] | ||
| address = 0x10000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| address = 0x10000 | |
| address = 0x1000 |
That's enough and will generate smaller numbers everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.