Closed
Conversation
redianthus
force-pushed
the
ocaml
branch
2 times, most recently
from
06f86cf to
e67b22b
Compare
Author
|
Updated the commit, removing almost all of the white-space changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed most of the warnings when compiling with
4.06.0. Except those like:this pattern-matching is not exhaustive, as doing something better than:_ -> assert falsewould take more time (but I'll try to have a look at it later).My editor also removed a lot of trailing white-spaces, once #7 is merged, I'll rebase this one so we'll only see the fix for the warnings, easing the review of the PR.