Skip to content

Conversation

@remzy-coder
Copy link
Owner

Summary

  • add Cloud Shell pre-flight validation, App Engine bootstrap, expanded IAM bindings, and resource verification to the deployment script for one-shot execution
  • document new environment variables, verification checklist, and scheduler/App Engine behavior in the README
  • refresh the architecture overview to reflect enhanced IAM, scheduler cadence, and bootstrap verification flow

Testing

  • make test (ran three times)
  • make test (ran three times)
  • make test (ran three times)

https://chatgpt.com/codex/tasks/task_e_68ed676c18188327a5d3be9ce5c3813c

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +377 to +384
echo "==> Creating Scheduler jobs"
if ! gcloud scheduler jobs describe odds-refresh --location="$SCHEDULER_LOCATION" >/dev/null 2>&1; then
gcloud scheduler jobs create http odds-refresh \
--location="$SCHEDULER_LOCATION" \
--schedule="*/5 * * * *" \
--uri="https://${REGION}-run.googleapis.com/apis/run.googleapis.com/v1/namespaces/${PROJECT_ID}/services/xmind-odds-aggregator:run" \
--http-method=POST \
--oidc-service-account-email="orchestrator-sa@$PROJECT_ID.iam.gserviceaccount.com"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix Scheduler target to call Cloud Run service URL

The odds-refresh job posts to https://${REGION}-run.googleapis.com/apis/run.googleapis.com/v1/namespaces/${PROJECT_ID}/services/xmind-odds-aggregator:run, which is a Cloud Run admin API endpoint used for job execution, not for invoking HTTP services. Cloud Scheduler HTTP targets expect a standard service URL (e.g. the status.url returned by gcloud run services describe); the current URI will return 404/403 and the odds aggregator will never be triggered. Use the Cloud Run service URL or a Pub/Sub intermediary so the scheduler can successfully invoke the service.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants