docs: add proposer field to README Before/After example#11
Merged
Conversation
ADR-002 made `Proposal.proposer` required, but the README's Before/After example still omitted it, so the snippet no longer compiled against the current API. Add `proposer: "cleanup-bot"` to keep the example runnable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe README's "After" example for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
renasami
added a commit
that referenced
this pull request
Apr 19, 2026
Code examples already include proposer (PR #11), but the README didn't explain what it represents or why it's required. Add a short paragraph after Quick Start that defines proposer, notes it must be non-anonymous, and links to ADR-002 for the audit-trail attribution rationale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
renasami
added a commit
that referenced
this pull request
Apr 19, 2026
…14) Code examples already include proposer (PR #11), but the README didn't explain what it represents or why it's required. Add a short paragraph after Quick Start that defines proposer, notes it must be non-anonymous, and links to ADR-002 for the audit-trail attribution rationale. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposal.proposerを必須化したが、README Before/After の例にproposerが無くコンパイルが通らなかったproposer: "cleanup-bot"を追加ADR-002 の Action Items に記載されていたまま残っていた小さな負債の解消です。
Test plan
pnpm run typecheckpass🤖 Generated with Claude Code
Summary by CodeRabbit