Skip to content

Improve <FocusManager /> types #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Improve <FocusManager /> types #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/index.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,13 @@ type FocusManagerChange = (focused: boolean) => void
type FocusManagerRender = ({|
focused: boolean,
blur: () => void,
bind: {| tabIndex: number, onFocus: () => void, onBlur: () => void |},
bind: {|
tabIndex: number,
onFocus: () => void,
onBlur: () => void,
onMouseDown: () => void,
onMouseUp: () => void,
|},
|}) => React.Node

declare export var FocusManager: React.ComponentType<
Expand Down
6 changes: 6 additions & 0 deletions tests/test_flow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,18 @@ const noop = () => null
;(blur: Function)
;(bind.onFocus: Function)
;(bind.onBlur: Function)
;(bind.onMouseDown: Function)
;(bind.onMouseUp: Function)
// $FlowFixMe
;(focused: number)
// $FlowFixMe
;(bind.onFocus: number)
// $FlowFixMe
;(bind.onBlur: number)
// $FlowFixMe
;(bind.onMouseDown: number)
// $FlowFixMe
;(bind.onMouseUp: number)
return null
}
const onChange = focused => {
Expand Down
8 changes: 7 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ export type FocusManagerChange = Callback<boolean>
export type FocusManagerRender = RenderFn<{
focused: boolean
blur: () => void
bind: { tabIndex: number; onFocus: () => void; onBlur: () => void }
bind: {
tabIndex: number
onFocus: () => void
onBlur: () => void
onMouseDown: () => void
onMouseUp: () => void
}
}>

export const FocusManager: React.ComponentType<
Expand Down