Change compose to pass list of props instead of object #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Feb 1, 2018
README.md
Outdated
| <br /> | ||
|
|
||
| > This branch is **unstable** and is in **active development**. | ||
| > This branch is **unstable** and is in **active development**. |
Collaborator
There was a problem hiding this comment.
Did you remove double space in the end?
Contributor
Author
There was a problem hiding this comment.
Oh sorry, it probably is my editor configured to remove trailing whitespace. I can add it back if you want.
Owner
There was a problem hiding this comment.
Two trailing whitespaces in markdown is a line break, it's make difference. 😢
Contributor
Author
There was a problem hiding this comment.
Ooops, did not know that. I'll fix it and fix my editor settings. Sorry.
Collaborator
|
@gnapse There's a lot more. Look at diff. |
Contributor
Author
|
Think I fixed them all now. Sorry. First time I see this markdown feature. |
Owner
|
I'll review & merge this soon |
Owner
|
Thanks @gnapse :) |
Contributor
Author
|
Always happy to contribute to open source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47