Skip to content

Pin dependency versions#1143

Merged
kjaymiller merged 1 commit intomainfrom
1130-pin-dependencies
Mar 22, 2026
Merged

Pin dependency versions#1143
kjaymiller merged 1 commit intomainfrom
1130-pin-dependencies

Conversation

@kjaymiller
Copy link
Copy Markdown
Collaborator

@kjaymiller kjaymiller commented Mar 22, 2026

Pins all dependency versions in pyproject.toml to exact versions and adds a pin-versions pre-commit hook to enforce pinning going forward.

Closes #1130

Type of Issue

  • 🐛 (bug)
  • 📖 (Documentation)
  • ⬆️ (Update)
  • 💫 (New Feature)
  • ☢️ (Deprecation)
  • 🚫 (Removal)
  • 🛠️ (Refactor)

Changes have been Documented (If Applicable)

  • YES - Changes have been documented

Changes have been Tested

  • YES - Changes have been tested

Next Steps

None

AI Attestation

Claude Code assisted with PR descriptions creation.

cli = ["render-engine-cli"]
extras = ["render-engine-sitemap"]
cli = ["render-engine-cli==2025.11.1"]
extras = ["render-engine-sitemap==2024.1.1a1"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this anymore?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the sitemap anymore, but you would bet able to tell me better than I can tell you.

This is for XML sitemap generation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SiteMap class will do that if a flag is set.

"ephemeral-port-reserve==1.1.4",
"deptry>=0.24.0",
"httpx",
"httpx==0.28.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use httpx for?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure at this point. I think it would be safe to remove. But that should be a separate issue.

@kjaymiller kjaymiller merged commit bcfaed3 into main Mar 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

We should probably pin all the dependencies, even if right now this is the only thing that breaks.

2 participants