Use fetch-depth: 0 so setuptools_scm picks up tags in CI#1170
Use fetch-depth: 0 so setuptools_scm picks up tags in CI#1170kjaymiller wants to merge 2 commits into
Conversation
Without fetch-depth: 0, the checkout is shallow with no tags, and setuptools_scm falls back to a 0.0.dev version. That breaks uv resolution on any PR that updates pyproject.toml without updating uv.lock, because the cli extra pins render-engine-cli, which in turn requires render-engine>=2025.11.1a1. Fixes #1169 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
As with all issues when it comes to workflows we can't test all that effectively until it's merged |
brass75
left a comment
There was a problem hiding this comment.
I hope this does what you think it does because I have no idea.
|
hmmm maybe we try dlemstra/Magick.NET#1528 (comment) |
Great challenge on this. I'm glad we have AI Attestation to make us reconsider.. the link above was found by me (not ai) |
Based on this I think all we would need is |
|
Set up two test branches to verify whether
Trigger: gh workflow run "PyTest" --ref issue-1169-test-fetch-tags
gh workflow run "PyTest" --ref issue-1169-test-depth-0If #1171 passes, Both branches are labeled |
|
I think the |
|
Results in:
The
This PR's |
Same setuptools_scm shallow-checkout failure mode as test.yml: ty_check re-resolves via uv and trips the self-referential `cli` extra; publish.yml runs `uv build` for releases and would otherwise bake `0.0.dev0` into the wheel shipped to PyPI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
fetch-depth: 0to all threeactions/checkoutsteps in.github/workflows/test.yml.setuptools_scmfalls back to0.0.dev…, and uv re-resolution fails on dependabot PRs that touchpyproject.tomlwithout updatinguv.lock(see Bump the production group across 1 directory with 3 updates #1164 for a live example).Fixes #1169
Test plan
test-against-python-matrixjobs pass on this PR.@dependabot rebaseon Bump the production group across 1 directory with 3 updates #1164 and confirm its matrix turns green.🤖 Generated with Claude Code