This repository was archived by the owner on Nov 19, 2024. It is now read-only.
adds render services env to show environmental variables#60
Closed
Eunoia wants to merge 0 commit intorender-oss:mainfrom
Closed
adds render services env to show environmental variables#60Eunoia wants to merge 0 commit intorender-oss:mainfrom
render services env to show environmental variables#60Eunoia wants to merge 0 commit intorender-oss:mainfrom
Conversation
render show env-varsrender services env to show environmental variables
Contributor
|
This looks great! Thanks for doing it. Code looks good and I'd like to get it in. I just pushed up #61 to fix the dependencies issue. Once that is merged, maybe we can modify this to just have the necessary JS changes to add the feature (I'd like to keep the PRs distinct). |
a0899ba to
7ae178b
Compare
|
Was this work ever merged into the main branch? I'm also interested in the functionality it adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time user, first time pull request opener.
Was checking out render, and I'm very pleased with how easier it was to get a new rails app up and running.
Part of my workflow is copying data from my local postgresql database to the production database using using pgsync. To avoid committing my DATABASE_URL in a config file, I was hoping to use a command line tool to pull the url from the app, like in
eb printenv, orheroku config. Seeing none, I added this to the render-cli project.Other people are interested in this too, AleksaButterfly and Robby Helms have asked about this feature.
The interface isn't the same as
heroku config, but this is better than the current solution. I'm happy to reimplementheroku configif that's the requirement.Demo
On merging
When starting on this project, I was getting this error when installing dependencies:
I was able to fix with
deno cache --lock=deps-lock.json deps.ts --lock-write, but this updated many packages, which may be bad. However, the build was able to pass, and that's pretty good. I'm not sure what the fix here is, but I'm happy to run the proper commands before this gets merged. Alternatively, feel free to edit this PR before merging it.