fix(ci): smoke retry defeated by errexit; idempotent npm publish#14
Merged
Conversation
The smoke step runs under GitHub''s default `bash -e`. Inside the backoff loop, `OUTPUT=$(npx -y @rendobar/mcp@VERSION ...)` returns non-zero when the npm CDN hasn''t propagated yet (~30s after publish), and errexit aborts the step before EXIT is captured or any retry runs — the 5x/150s backoff never executes. v1.0.2 published fine but smoke failed on attempt 1, skipping the GitHub Release + MCP registry steps. Add `set +e` so the loop owns its control flow. Also make the publish step idempotent: skip if the version is already on npm, so a recovery re-run (or a manual dispatch to backfill a skipped downstream step) doesn''t 403 on the existing version.
This was referenced May 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The v1.0.2 release published to npm fine but
release.ymlreported failure — the smoke test died on attempt 1 (exit 127), skipping Create GitHub Release + MCP registry and opening issue #13.Root cause
The smoke step runs under GitHub's default
bash -e. Inside the backoff loop,OUTPUT=$(npx -y @rendobar/mcp@VERSION ...)returns non-zero when the npm CDN hasn't propagated yet (~30s post-publish).set -eaborts the step beforeEXIT=$?is captured or any retry runs — the 5×/150s backoff is dead code on a first miss. 1.0.1 got lucky with fast propagation.Fix
set +ein the smoke step so its own retry loop owns control flow.workflow_dispatchto backfill a skipped downstream step doesn't 403 on the existing version.Note (already recovered manually)
@rendobar/mcp@1.0.2is live + verified (npx … --version→ 1.0.2).workflow_dispatch(tag=v1.0.2) once this merges, then close Release v1.0.2 failed #13.