chore: pin Biome to 2.4.15 and clear auto-fixable lint debt#14
Merged
Conversation
Apply biome check --write --unsafe (27 mechanical fixes across 9 files: Number.isFinite, parseInt radix, template literals, optional chaining) and pin @biomejs/biome from ^2.4.15 to 2.4.15 so a future patch can't shift rule severities and break CI on unrelated PRs. Tests: 113/113. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clears the auto-fixable Biome lint debt and pins the Biome version so CI stays deterministic.
Changes
@biomejs/biometo exact2.4.15(was^2.4.15). A caret range lets a future patch silently change rule severities or import-sort behavior and break CI on unrelated PRs. Thebiome.jsonschema is already pinned to2.4.15, so this just aligns the dependency.biome check --write --unsafe(27 fixes across 9 files), all mechanical and behavior-preserving:isFinite(n)>Number.isFinite(n)(avoids global coercion)parseInt(x)>parseInt(x, 10)(explicit radix)npm teststays green (113/113).Left intentionally
The 11 remaining
noAssignInExpressionswarnings are all the idiomatic(x.y ??= [])nullish-assign pattern. They're already configured aswarn(non-blocking) inbiome.json, and rewriting them would only uglify the code. Left as-is — happy to disable that rule or refactor if you'd prefer.Why now
Contributors running
biome check --write --unsafe(or editors with fix-on-save) were getting ~9 unrelated files rewritten under them, which discouraged running the linter at all. With these landed, the linter is a clean no-op on untouched files.Note: this does not touch
assist/source/organizeImportsenforcement — that's the one error-level check, and it correctly catches unsorted imports in new PRs.