gomodUpdateImportPaths only works correctly with a single major upgrade

[tokongs]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Wanted end result.

A major-golang Renovate PR in which all major updates are updated with their respective import paths in the go source files.

What you tried so far.

1. Enable gomodUpdateImportPaths
2. Get PR with multiple major updates
3. All the dependencies will have their import paths updated with the version of the first dependency

My question is just if this is intended behavior or if it is a bug. The responsible code seems to be here

renovate/lib/modules/manager/gomod/artifacts.ts

Lines 114 to 124 in 9338b2c

	function getUpdateImportPathCmds(
	updatedDeps: PackageDependency[],
	{ constraints, newMajor }: UpdateArtifactsConfig
	): string[] {
	const updateImportCommands = updatedDeps
	.map((dep) => dep.depName!)
	.filter((x) => !x.startsWith('gopkg.in'))
	// TODO: types (#7154)
	// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
	.map((depName) => `mod upgrade --mod-name=${depName} -t=${newMajor}`);

Relevant debug logs

Logs

The command that's running

"install-tool golang 1.19.5 && go get -d -t ./... && go install github.com/marwan-at-work/mod/cmd/mod@latest && mod upgrade --mod-name=github.com/caarlos0/env/v6 -t=7 && mod upgrade --mod-name=github.com/google/go-github/v47 -t=7 && mod upgrade --mod-name=github.com/hashicorp/golang-lru -t=7 && mod upgrade --mod-name=github.com/pelletier/go-toml -t=7 && mod upgrade --mod-name=github.com/twpayne/go-vfs -t=7 && go mod tidy && go mod tidy\"

[github-actions[bot]]

Hi there,

We have found that there's a problem with the logs. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Renovate app (GitHub):

1. Go to the affected PR, and search for "View repository job log here"
2. Select the link to go to the "Mend Renovate Dashboard" and log in
3. You are now in the correct repository log overview screen
4. Copy/paste the correct log
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

If you're running self-hosted, run with LOG_LEVEL=debug in your environment variables and search for whatever dependency/branch/PR that is causing the problem.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

[rarkins]

You can see in the logs the exact commands run. Next step would be to identify which commands should be run instead

[tokongs]

"install-tool golang 1.19.5 && go get -d -t ./... && go install github.com/marwan-at-work/mod/cmd/mod@latest && mod upgrade --mod-name=github.com/caarlos0/env/v6 -t=7 && mod upgrade --mod-name=github.com/google/go-github/v47 -t=7 && mod upgrade --mod-name=github.com/hashicorp/golang-lru -t=7 && mod upgrade --mod-name=github.com/pelletier/go-toml -t=7 && mod upgrade --mod-name=github.com/twpayne/go-vfs -t=7 && go mod tidy && go mod tidy\"

This is the command being run -t=7 for every major dependency upgrade. Which is right for the github.com/caarlos0/env/v6 dependency, but wrong for everything else.

[rarkins]

Sounds like it could be reproduced with two updates, as long as they're a different newMajor. Please raise a bug report issue with reproduction attached (instructions below). It could potentially be fixed with code inspection/unit testing only, but it's preferred if we can have a reproduction to be more sure.

[github-actions[bot]]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team