Renovate PRs do not honor required checks

[omercnet]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitHub

Please tell us more about your question or problem

see descope/assume-aws-role-from-gcp-action#80

A PR was opened and merged immediately (all within the same minute) even tho there were failed checks

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[HonkingGoose]

Question for you

A PR was opened and merged immediately (all within the same minute) even tho there were failed checks

Did you tell GitHub to wait for those tests to pass before GitHub is allowed to merge the PR?

Renovate docs warning about automerge without required status checks

The Renovate automerge docs have this warning:

Automerge and GitHub branch protection rules

You must select at least one status check in the Require status checks to pass before merging section of your branch protection rules on GitHub, if you match all three conditions:

• automerge=true
• platformAutomerge=true, Renovate defaults to true
• You use GitHub's Require status checks to pass before merging branch protection rule

If you don't select any status check, and you use platform automerge, then GitHub might automerge PRs with failing tests!

References

• GitHub Docs, require status checks before merging
• GitHub Docs, troubleshooting required status checks
• Renovate Docs, automerge (search for: Automerge and GitHub branch protection rules)

[omercnet]

of course, see other PRs in same repo
descope/assume-aws-role-from-gcp-action#78

seems the PR was opened and merge so quickly before github had a chance to launch and update the pending checks for this PR

[rarkins]

No, that cannot be correct. If you have set branch protection correctly, GitHub will enforce it no matter what. If it does not, then it's a GitHub bug.