forgejo: how is "support teams as reviewer" supposed to work?

[LeSpocky]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Forgejo 12.0.1, renovate 41.82.3 (Docker)

Please tell us more about your question or problem

After upgrading to post 41.78.0, I thought "feat(forgejo): support teams as reviewer #37589" would be a nice addition to our workflow. I expected renovate to add a team in the reviewers section of a new PR. So I added this to the renovate.json of the repo where renovate should add that team to a PR (names redacted):

diff --git a/renovate.json b/renovate.json
index 34d189f..abcd7b7 100644
--- a/renovate.json
+++ b/renovate.json
@@ -29,5 +29,6 @@
       "matchPackageNames": [ "renovate/renovate" ],
       "schedule": [ "before 1am on friday" ]
     }
-  ]
+  ],
+  "reviewers": ["MyOrganization/MyTeam"]
 }

The whole config looks like this now:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "configMigration": true,
  "customManagers": [
    {
      "customType": "regex",
      "managerFilePatterns": [
        "/^group-.*\\.yml$/",
        "/^host-.*\\.yml$/",
        "/^host_vars/.*/vars\\.yml$/"
      ],
      "datasourceTemplate": "docker",
      "versioningTemplate": "docker",
      "matchStrings": [
        "image: (?<depName>.*?):(?<currentValue>.*?)(@(?<currentDigest>sha256:.*?))?\\s"
      ]
    }
  ],
  "packageRules": [
    {
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "renovate/renovate"
      ],
      "matchUpdateTypes": [
        "patch"
      ],
      "schedule": [
        "before 1am on friday"
      ],
      "automerge": true
    },
    {
      "matchDatasources": [
        "docker"
      ],
      "matchPackageNames": [
        "renovate/renovate"
      ],
      "schedule": [
        "before 1am on friday"
      ]
    }
  ],
  "reviewers": [
    "MyOrganization/MyTeam"
  ]
}

So I basically added the reviewers list at the end of the config. This is how I understood the documentation. But as you would guess: this does not work, there's no reviewer added to the PR.

renovate itself is run in a cron job and called like this (redacted):

docker run --rm \
        -e RENOVATE_TOKEN=**** \
        -e RENOVATE_ENDPOINT=https://*****/api/v1 \
        -e RENOVATE_PLATFORM=forgejo \
        -e RENOVATE_GIT_AUTHOR='Renovate Bot <accounts+renovatebot@*****>' \
        -e GITHUB_COM_TOKEN=***** \
        renovate/renovate:41.82.3 --autodiscover

I'd say the docs are somewhat thin on how to use is. Is it even possible to let renovate add a forgejo team to the reviewers list?

I found no relevant hints in the debug logs and config validation is successful.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[viceice]

I've implemented it but only with unit tests. I'll debug it when I've some time.

[viceice]

• fix(forgejo): properly handle team reviewers #39533

[LeSpocky]

Just wanted to let you know, after upgrading to the recent renovate version from today, it works with this setting here:

{
  "reviewers": [ "team:Admins" ]
}

Thanks for your effort. 😃