Github PR Re-request for Dismissed Approvals #43482
sp3nx0r
started this conversation in
Suggest an Idea
Replies: 1 comment 5 replies
-
|
Sounds good to me. |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Tell us more.
#43463
We utilize Github's "dismiss stale pull request approvals" on many repos, and when Renovate rebases or bumps versions, the previous approvals become dismissed and doesn't automatically re-request review from those approvers. This then means that the PR falls off the approvers' radar (because it doesn't show up in their review queue either in Github or our custom review queue we use internally). It'd be pretty simple for Renovate to re-request the prior approval.
I submitted a PR that is actively being used for our self-hosted Renovate setup that re-requests the review. Would appreciate this getting taken upstream as it'd be an improvement on the existing Renovate flow. Thanks
Beta Was this translation helpful? Give feedback.
All reactions