copier manager: resolve SSH _src_path over HTTPS via hostRules (like git-submodules) #44528
jfra1397
started this conversation in
Suggest an Idea
Replies: 2 comments
-
|
Sounds good. PR welcome |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
PR opened: #44552 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Tell us more.
Describe the proposed change(s)
The
copiermanager forwards the_src_pathfrom.copier-answers.ymlto thegit-tagsdatasource as thepackageName. Since #41725 thegit+prefix is correctly stripped, so agit+ssh://…source becomesssh://git@host/….However, the copier manager does no host-aware URL normalization: an
ssh://source is looked up over SSH verbatim. On a Renovate bot that authenticates to the host over HTTPS only (no SSH key), the lookup fails:The
git-submodulesmanager does not have this problem: it normalizes SSH submodule URLs to HTTPS and applies the matchinghostRules/token before lookup. So a repo with an SSH submodule resolves fine on an HTTPS-only bot, while the same repo's SSH copier_src_pathfails. That asymmetry is surprising.Describe the solution you'd like
When a
hostRule(or platform token) provides HTTPS credentials for the host of anssh:///git+ssh://copier_src_path, the copier manager should resolve it the waygit-submodulesalready does — convert to the HTTPS form and attach the token — rather than attempting a raw SSHls-remote.Beta Was this translation helpful? Give feedback.
All reactions