Skip to content

Conversation

@kayman-mk
Copy link

@kayman-mk kayman-mk commented Apr 5, 2024

Changes

This PR adds a new datasource to update the versioned layer arns for AWS Lambda Layers.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

kayman-mk and others added 28 commits November 22, 2022 09:14
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
…apag-Lloyd/renovate into kayma/add-aws-versioned-arn-datasource
@kayman-mk
Copy link
Author

kayman-mk commented Apr 5, 2024

Reopens #19081

I stopped working on that PR because I found out that you usually do not have the lambda:listLayerVersion policy for layers you do not own. So I thought this whole datasource didn't make any sense. But in fact it is useful as we found out in a team internal discussion today:

  • you can use it to update lambda layers you own
  • you can ask the maintainer of the layer you do not own to add the respective permission so Renovate can list the version numbers as well
aws lambda add-layer-version-permission \
    --layer-name my-layer \
    --statement-id xaccount \
    --action lambda:ListLayerVersions  \
    --principal 123456789012 \
    --version-number 1

@kayman-mk
Copy link
Author

Still have to work on the documentation

@kayman-mk
Copy link
Author

Still struggeling with the pnpm-lock.yaml. How can I regenerate the file so it includes my changes?

});

describe('getReleases', () => {
it('should throw an exception if the filter criteria does not match the schema', async () => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice Is this assumption correct? If not: how to catch this error?

try {
  FilterParser.parse(xxxx);
} catch (e) {
  // log error and return null
}

Looks ugly and I guess there is a better option. Checking the existing source, I didn't find any.

@rarkins rarkins added the auto:inactive-pr PR has become inactive and we want to prompt the submitter label Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hi there,

This PR appears to have been inactive for a while. Please let us know if you are still working on it, or if we can close it for now.

Thanks, the Renovate team

@rarkins rarkins added the auto:close-inactive-pr Inactive PR should be closed label Apr 27, 2025
@github-actions
Copy link
Contributor

Hi there,

We're closing this PR due to inactivity, but we are happy for you, or others, to finish the PR if time allows.

Thanks, the Renovate team

@github-actions github-actions bot closed this Apr 27, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto:close-inactive-pr Inactive PR should be closed auto:inactive-pr PR has become inactive and we want to prompt the submitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants