-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(yaml): handle when templates are used as Yaml keys #33361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yaml): handle when templates are used as Yaml keys #33361
Conversation
|
I see a lot of side effect especially for Helm charts here… I have no problems to invest more time, but maybe it would be better to discuss if the way I'm doing it here is acceptable first. |
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing tests
| } | ||
|
|
||
| function getShortHash(data: any): string { | ||
| return crypto.createHash('sha256').update(data).digest('hex').substring(0, 7); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've a hash util function, please use that
| @@ -0,0 +1,26 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduce to minimum and inline
|
Please open a separate discussions regarding this scenario so we can discuss the solution. You can tag me there. |
|
Hi there, We're closing this PR due to inactivity, but we are happy for you, or others, to finish the PR if time allows. Thanks, the Renovate team |
Changes
This add support for cases where templates are used as key in Yaml files.
Context
See: #18470 (reply in thread)
For example, when having a
docker-compose.yaml.j2file like the following:Renovate was failing with the following error:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: