-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(github-actions): add some community action support #34791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm waiting for response from reviewers |
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
|
I'm not sure why e2e test failed.... |
|
the e2e tests failure is caused by a upstream bug fb55/css-select#1592 |
|
Should we add a resolutions override to main? |
yes |
|
@RahulGautamSingh can you? |
|
it's fixed in upstream, so I think we do not need it now. But i can't re-trigger the e2e ci. |
|
can we have some code review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add some explanation in the readme file related tot he actions in the community.ts file?
↑ Not needed
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
|
🎉 This PR is included in version 41.58.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
add support for github actions
astral-sh/setup-uvjaxxstorm/action-install-gh-releasepnpm/action-setupprefix-dev/setup-pixiContext
pnpm/action-setupwithversion:updates #34767Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: