Skip to content

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented Mar 13, 2025

Changes

add support for github actions

  • astral-sh/setup-uv
  • jaxxstorm/action-install-gh-release
  • pnpm/action-setup
  • prefix-dev/setup-pixi

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Mar 13, 2025
@trim21 trim21 marked this pull request as draft March 13, 2025 21:45
@trim21
Copy link
Contributor Author

trim21 commented Jun 28, 2025

I'm waiting for response from reviewers

@RahulGautamSingh RahulGautamSingh requested a review from viceice June 28, 2025 10:44
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@trim21
Copy link
Contributor Author

trim21 commented Jun 28, 2025

I'm not sure why e2e test failed....

@trim21
Copy link
Contributor Author

trim21 commented Jun 28, 2025

the e2e tests failure is caused by a upstream bug fb55/css-select#1592

@trim21 trim21 requested a review from viceice June 28, 2025 14:53
@rarkins
Copy link
Contributor

rarkins commented Jun 28, 2025

Should we add a resolutions override to main?

@trim21
Copy link
Contributor Author

trim21 commented Jun 28, 2025

Should we add a resolutions override to main?

yes

@rarkins
Copy link
Contributor

rarkins commented Jun 28, 2025

@RahulGautamSingh can you?

@trim21
Copy link
Contributor Author

trim21 commented Jun 28, 2025

it's fixed in upstream, so I think we do not need it now.

But i can't re-trigger the e2e ci.

@rarkins rarkins removed the auto:inactive-pr PR has become inactive and we want to prompt the submitter label Jun 28, 2025
@trim21
Copy link
Contributor Author

trim21 commented Jul 17, 2025

can we have some code review on this?

Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some explanation in the readme file related tot he actions in the community.ts file?

↑ Not needed

trim21 and others added 2 commits August 7, 2025 22:06
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
@trim21 trim21 requested a review from viceice August 7, 2025 15:23
@viceice viceice added this pull request to the merge queue Aug 7, 2025
Merged via the queue into renovatebot:main with commit ff290b2 Aug 7, 2025
40 checks passed
@renovate-release
Copy link

🎉 This PR is included in version 41.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@trim21 trim21 deleted the feat/binary-action branch August 7, 2025 17:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for pnpm/action-setup with version: updates

7 participants