feat(datasource/deb): support multiple releases/suites #34902
Conversation
| function getReleaseParam(url: URL, optionalParams: string[]): string { | ||
| for (const param of optionalParams) { | ||
| function getReleaseParam(url: URL, optionalParams: string[]): string[] { | ||
| const releases = optionalParams.flatMap((param) => { |
There was a problem hiding this comment.
revert the flat map and directly return the found value as before, otherwise you return values of all optional params.
There was a problem hiding this comment.
Why do you think it's a problem? There's no real difference between release and suite - why not merge their values?
There was a problem hiding this comment.
Why should suite be silently ignored in https://archive.ubuntu.com/ubuntu?suite=noble&release=noble-updates&components=main&binaryArch=amd64? Previously the rest of the code wasn't capable of querying multiple releases, so it (somewhat) made sense. But these are just two names for the same thing, suite=noble and release=noble give exactly the same results. Not sure why the documentation is written as if these are different (IMO it's wrong).
https://manpages.debian.org/testing/apt/sources.list.5.en.html also has an example with Suites: bookworm bookworm-updates - what https://docs.renovatebot.com/modules/datasource/deb/ calls "releases".
There was a problem hiding this comment.
It was probably an error to add suite and release but they aren't allowed both at the same time.
So they still shouldn't be used at the same time and we should only mention the official name in docs.
And don't merge them.
There was a problem hiding this comment.
There was a problem hiding this comment.
you can now merge from main and do the required changes.
you only need to support multiple suites, not multiple releases.
|
Hi there, We're closing this PR due to inactivity, but we are happy for you, or others, to finish the PR if time allows. Thanks, the Renovate team |
3 participants
Changes
Allow multiple release codenames/suite names to be included in
registryUrlContext
Both Ubuntu and Debian have
*-updatespesudo-release (noble-updatesfor Ubuntunoble). Post-release package updates usually get uploaded there. Then, when a patch release of Ubuntu or Debian happens, all packages are moved to the main release repository.To track the latest version of the package, that would be installed by
apt-get install <package>in the default configuration, packages from multiple releases/suites need to be merged.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: