-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: add option skipArtifactsUpdate
#35993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option skipArtifactsUpdate
#35993
Conversation
Co-authored-by: RahulGautamSingh <rahultesnik@gmail.com>
|
Is there anything else needed for this to be merged? |
|
@RahulGautamSingh @viceice have either of you had the chance to test this on some real examples? This has the chance to break a lot of people if it has a bug |
|
I will test tonight +5.30 GMT |
RahulGautamSingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
|
Note: When user disable artifact updates they will involuntarily receive wrong updates for the Example:
|
|
Please add that warning to the docs |
Head branch was pushed to by a user without write access
|
Anything else needed? |
|
🎉 This PR is included in version 41.62.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This adds a new option called
skipArtifactsUpdate. When set to true, artifact updating will be skipped.This new option replaces the existing
updateLockFilesoption. A migration will replaceupdateLockFiles=falsewithskipArtifactsUpdate=true.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: