Skip to content

Conversation

@reduckted
Copy link
Contributor

@reduckted reduckted commented May 17, 2025

Changes

This adds a new option called skipArtifactsUpdate. When set to true, artifact updating will be skipped.

This new option replaces the existing updateLockFiles option. A migration will replace updateLockFiles=false with skipArtifactsUpdate=true.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@reduckted reduckted requested a review from viceice May 18, 2025 12:34
@reduckted reduckted requested a review from viceice May 21, 2025 11:49
@reduckted reduckted requested a review from rarkins May 25, 2025 05:05
viceice
viceice previously approved these changes May 25, 2025
Co-authored-by: RahulGautamSingh <rahultesnik@gmail.com>
viceice
viceice previously approved these changes Jun 23, 2025
@reduckted
Copy link
Contributor Author

Is there anything else needed for this to be merged?

@rarkins rarkins enabled auto-merge July 8, 2025 10:10
@rarkins
Copy link
Contributor

rarkins commented Jul 8, 2025

@RahulGautamSingh @viceice have either of you had the chance to test this on some real examples? This has the chance to break a lot of people if it has a bug

@RahulGautamSingh
Copy link
Collaborator

I will test tonight +5.30 GMT

Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jul 17, 2025

Note:

When user disable artifact updates they will involuntarily receive wrong updates for the packageManager field in their package.json files if the version string contains a hash as we trigger corepack update in the updateArtifacts function for the npm manager module.

Example:

packageManager: "pnpm@1.2.0" this will get updated correctly ✅

packageManager: "yarn@3.0.0+sha224.deadbeef" this will get updated to "yarn@3.1.0"

@rarkins
Copy link
Contributor

rarkins commented Jul 18, 2025

Please add that warning to the docs

auto-merge was automatically disabled July 22, 2025 09:58

Head branch was pushed to by a user without write access

@RahulGautamSingh RahulGautamSingh requested review from rarkins and removed request for rarkins August 4, 2025 12:15
@reduckted
Copy link
Contributor Author

Anything else needed?

@rarkins rarkins added this pull request to the merge queue Aug 11, 2025
Merged via the queue into renovatebot:main with commit a3616a4 Aug 11, 2025
46 of 60 checks passed
@reduckted reduckted deleted the feature/33118-skip-artifact-updating branch August 11, 2025 09:19
@renovate-release
Copy link

🎉 This PR is included in version 41.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New option: skipArtifactUpdating

5 participants