Skip to content

feat(datasource/custom): add toml support #36136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rarkins merged 10 commits into from
Jun 29, 2025
Merged

feat(datasource/custom): add toml support #36136

rarkins merged 10 commits into from
Jun 29, 2025

Conversation

@RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 25, 2025

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed May 25, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice May 25, 2025 13:19
viceice
viceice reviewed May 25, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice May 28, 2025 09:52
viceice
viceice reviewed Jun 4, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice June 5, 2025 00:21
viceice
viceice reviewed Jun 5, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing tests / missing coverage

@rarkins rarkins requested a review from viceice June 7, 2025 06:38
rarkins
rarkins suggested changes Jun 7, 2025
View reviewed changes
viceice
viceice reviewed Jun 7, 2025
View reviewed changes
RahulGautamSingh and others added 2 commits June 8, 2025 23:21
@RahulGautamSingh @rarkins @viceice
Apply suggestions from code review
bc04059 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh
refactor
4fdf9fd
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 28, 2025

Needs attention :)

@RahulGautamSingh RahulGautamSingh mentioned this pull request Jun 28, 2025
Closed
6 tasks
viceice
viceice reviewed Jun 28, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@rarkins rarkins enabled auto-merge June 29, 2025 06:00
@rarkins rarkins added this pull request to the merge queue Jun 29, 2025
Merged via the queue into renovatebot:main with commit c477fb0 Jun 29, 2025
40 checks passed
@renovate-release
Copy link

renovate-release commented Jun 29, 2025

🎉 This PR is included in version 41.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@viceice viceice viceice left review comments

@secustor secustor secustor approved these changes

+2 more reviewers

@rarkins rarkins rarkins approved these changes

@Fool256 Fool256 Fool256 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(datasource/custom): allow to fetch from TOML data endpoint

6 participants

@RahulGautamSingh @renovate-release @viceice @rarkins @secustor @Fool256