feat: structured logger #36199
feat: structured logger #36199
Conversation
| return problems.clearProblems(); | ||
| } | ||
|
|
||
| export function logFatal<C extends FatalCode, A extends AdditionalFieldsMap[C]>( |
There was a problem hiding this comment.
I wasn't able to make this fit into logger.fatal() but I'm open to that.
There was a problem hiding this comment.
This type came from ChatGPT. I tried using the Exact from type-fest instead, but it wasn't the same
secustor
left a comment
secustor
left a comment
There was a problem hiding this comment.
I'm for this, but maybe there should a default handler for errorMessage, if error has been provided as a field.
So that errorMessage: err.message is the default, but can be overwritten.
|
So make err:Error an optional field for all? |
| export async function generateErrors(dist: string): Promise<void> { | ||
| const errorFile = 'errors.md'; | ||
| let errorFileContents = await readFile(`docs/usage/${errorFile}`); | ||
| const errorTypes = ['fatal'] as const; |
| const errorTypes = ['fatal'] as const; | ||
| for (const errorType of errorTypes) { | ||
| const capitalizedType = | ||
| errorType.charAt(0).toUpperCase() + errorType.slice(1); |
There was a problem hiding this comment.
don't we have a util function already for this? 🤔
|
Hi there, We're closing this PR due to inactivity, but we are happy for you, or others, to finish the PR if time allows. Thanks, the Renovate team |
Changes
Adds new typed logging for fatal messages
Context
I would like to consolidate and strongly type all warn, error and fatal messages
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: