This repository was archived by the owner on Jun 6, 2025. It is now read-only.
chore(upgrades): upgrading packages #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @rentpath/react-ui-ag, @rentpath/react-ui-core, @rentpath/react-ui-tracking * upgraded date-fns * upgrade react and react-dom dependencies * remove react-ui-rent BREAKING CHANGE: date-fns needs to be upgraded in the repo using it
barelyfitz
approved these changes
Sep 6, 2019
Contributor
barelyfitz
left a comment
barelyfitz
left a comment
There was a problem hiding this comment.
Looks good:
- Notify rent / and ag teams about this
- Does react version in rent / ag also need to be updated (in addition to date-fns?)
- Create PRs against rent and ag to do this upgrade (at least to verify that tests pass)?
triedal
approved these changes
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @rentpath/react-ui-ag, @rentpath/react-ui-core, @rentpath/react-ui-tracking
BREAKING CHANGE:
date-fns needs to be upgraded in the repo using it