Add WalletConnect logger option#558
Conversation
🦋 Changeset detectedLatest commit: d56c6db The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @ignaciosantise's task in 2m 4s —— View job PR Review
Found 2 issue(s)Issue 1: Type duplication —
|
|
@claude review |
|
Claude finished @ignaciosantise's task in 1m 28s —— View job PR Review
🔄 Incremental Review: checking current code state against the two issues flagged in the previous auto-review. Resolved since last review:
Found 1 issue(s)Issue 1: Private helper loses type precision —
|
There was a problem hiding this comment.
Pull request overview
Adds an optional logger configuration to AppKit so SDK integrators can control WalletConnect (@walletconnect/universal-provider) log verbosity, while preserving default behavior when omitted.
Changes:
- Extend public types to include a WalletConnect logger level and expose it via
AppKitConfig.logger. - Thread
loggerthrough connector initialization and intoUniversalProvider.init(...). - Add a changeset describing the new option.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/common/src/types/wallet/connector.ts | Introduces WalletConnectLoggerLevel and adds logger? to ConnectorInitOptions. |
| packages/appkit/src/types.ts | Exposes logger? on AppKitConfig (public API surface). |
| packages/appkit/src/connectors/WalletConnectConnector.ts | Forwards logger into UniversalProvider.init during connector initialization. |
| packages/appkit/src/AppKit.ts | Passes logger from AppKit config into connector init(...) calls. |
| .changeset/walletconnect-logger-option.md | Adds release notes/versions for the new logger option. |
Comments suppressed due to low confidence (1)
packages/appkit/src/connectors/WalletConnectConnector.ts:94
getUniversalProvidertypesloggeras a plainstring, which weakens internal type-safety and allows accidental invalid values. Consider typing this parameter asWalletConnectLoggerLevel(orConnectorInitOptions['logger']) to keep it consistent with the public config type.
}: {
projectId: string;
metadata: Metadata;
logger?: string;
}): Promise<UniversalProvider> {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|



This adds a
loggeroption tocreateAppKitand forwards it through connector initialization into@walletconnect/universal-provider, with a changeset for the release.The public types now accept WalletConnect logger levels including
fatal, so consumers can disable or tune WalletConnect core logs without passing invalid values.This gives SDK integrators explicit control over WalletConnect logging while preserving the default behavior when
loggeris omitted.Validation:
yarn format,yarn lint, andyarn test.