chore: add wallet filter by namespace #4085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94f788a The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
enesozturk
reviewed
Mar 26, 2025
| wallet.chains?.some(chain => caipNetworkIds.includes(chain)) | ||
| ) | ||
|
|
||
| state.wallets = state.wallets.filter(wallet => |
Contributor
There was a problem hiding this comment.
Should we clear the filtering on top if namespace is undefined?
Contributor
There was a problem hiding this comment.
And after filtering first time, how to remove filter as the state.wallets are filtered before, it doesn have all the wallets 🤔
Collaborator
Author
There was a problem hiding this comment.
But isn't this reapplied every time the network specific button is clicked?
Collaborator
Author
There was a problem hiding this comment.
Changed the aproach to filter on fetch instead of here
Contributor
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
arein
reviewed
Apr 16, 2025
Contributor
arein
left a comment
arein
left a comment
There was a problem hiding this comment.
can you add a unit test Rocky for regressions?
0xmkh
approved these changes
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist