Skip to content

Conversation

@ganchoradkov
Copy link
Member

Description

Implemented guard mechanism in syncAccount so it runs once per address per 60s (configurable timeout). This is needed as an adapter can emit accountChanged multiple times for the same address/chain

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 1e67fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 9:44am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 9:44am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-basic-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-basic-up-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-nansen-demo ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-vue-solana ⬜️ Ignored (Inspect) May 23, 2025 9:44am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am
vue-wagmi-example ⬜️ Ignored (Inspect) May 23, 2025 9:44am

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Warnings
⚠️ File packages/appkit/src/client/appkit-base-client.ts contains a KEY or SECRET
⚠️ File packages/appkit/tests/client/public-methods.test.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 1e67fa2

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.3% 26936 / 35299
🔵 Statements 76.3% 26936 / 35299
🔵 Functions 67.94% 2274 / 3347
🔵 Branches 83.71% 5399 / 6449
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 74.88% 87.13% 77.66% 74.88% 171, 215-218, 232-233, 235-236, 241-242, 321-322, 358-364, 398-399, 420-426, 429-430, 447-448, 452, 459-460, 491-495, 508-522, 547-553, 557-569, 572-574, 577-579, 582-584, 587-589, 592-598, 601-603, 606-612, 628-640, 646-679, 682-692, 744-745, 751, 762-776, 782, 786-793, 806-810, 851, 893-897, 903-904, 916, 939-944, 1015, 1019-1020, 1026-1028, 1034-1035, 1064-1065, 1075, 1077-1093, 1098, 1137-1138, 1151-1162, 1195-1203, 1244, 1250-1254, 1283-1286, 1290, 1306-1316, 1338-1349, 1378-1379, 1385-1411, 1576-1577, 1609-1610, 1613-1614, 1629-1632, 1635-1636, 1656-1657, 1660-1661, 1683-1684, 1698, 1706, 1709, 1713, 1718-1737, 1740-1749, 1764-1765, 1808-1809, 1897-1898, 1901-1904, 1907-1908, 1911-1912, 1915-1916, 1919-1920, 1923-1927, 1936-1945, 1954-1965, 1345, 1720-1741
Generated in workflow #12053 for commit 1e67fa2 by the Vitest Coverage Report Action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants