fix: auth provider switch network while switching to another namespace #4361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted when using auth provider
… network on other namespace
🦋 Changeset detectedLatest commit: ccc52c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
11 Skipped Deployments
|
Contributor
|
Contributor
enesozturk
commented
May 16, 2025
enesozturk
changed the title
enesozturk
force-pushed
the
enes/apkt-2898-auth-provider-switching-namespace-doesnt-actually-switch
branch
from
1ead472 to
1d4a6a1
Compare
…pace-doesnt-actually-switch
…pace-doesnt-actually-switch
svenvoskamp
approved these changes
May 23, 2025
…pace-doesnt-actually-switch
…pace-doesnt-actually-switch
…pace-doesnt-actually-switch
enesozturk
force-pushed
the
enes/apkt-2898-auth-provider-switching-namespace-doesnt-actually-switch
branch
from
458e64b to
554a342
Compare
tomiir
deleted the
enes/apkt-2898-auth-provider-switching-namespace-doesnt-actually-switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Auth provider and switch network, our current business logic doesn't call the
adapter.switchNetworkif the switched namespace is already connected. This causing issues while switching to different network than the namespace's last active network.Reproduction steps
Bc in this condition we don't call
adapter.switchNetwork. This PR introduces changes to call it for proper network switching.Additionally, adds a
returnto unsupported network logic onChainController.switchActiveNetworkmethod where we are redirecting user to previous screen, but since we don't return the function, the code will be executed for the rest of the function body. We didn't came up with result of it but it's a possible issue.Type of change
Associated Issues
For Linear issues: Closes APKT-2936
For GH issues: closes #...
Showcase (Optional)
Before:
Screen.Recording.2025-05-16.at.15.56.38.mov
After:
Screen.Recording.2025-05-16.at.17.38.38.mov
Checklist