test(controllers): Add comprehensive error handling tests for ConnectionController (APKT-2901) #4364

devin-ai-integration · 2025-05-17T21:27:50Z

Add comprehensive error handling tests for ConnectionController (APKT-2901)

Description

This PR adds comprehensive error handling tests for the ConnectionController, organized by error category:

Connection Failures
- WalletConnect connection failures
- External wallet connection failures
- Connection failures during wallet switching
Timeout Scenarios
- WalletConnect pairing timeouts
- Transaction signing timeouts
- Connection timeout handling
Invalid Wallet Responses
- Malformed wallet data handling
- Unexpected response formats
- Empty or null wallet responses
- Invalid address formats
Network Disconnections
- Network disconnections during wallet operations
- Disconnections during transaction signing/sending
- Disconnect method failures
- Session clearing failures
Recovery Mechanisms
- Auto-retry functionality
- State reset and cleanup after errors
- User-initiated recovery actions
- Error boundary verification

Implementation Details

Used Vitest's mocking capabilities to simulate various error conditions
Added helper functions to verify error reporting and event sending
Used fake timers for timeout testing
Verified error boundary properly catches and processes errors
Tested error propagation through the error boundary
Verified UI error handling where applicable

Ticket

APKT-2901

Link to Devin run

https://app.devin.ai/sessions/92237a7e2e66477bb980b14b21efe222

Requested by

derek@reown.com

…ionController (APKT-2901) Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

linear · 2025-05-17T21:27:53Z

APKT-2901 Error Handling Tests for ConnectionController

changeset-bot · 2025-05-17T21:27:54Z

⚠️ No Changeset found

Latest commit: 578fb3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

devin-ai-integration · 2025-05-17T21:27:55Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

vercel · 2025-05-17T21:27:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-basic-html	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 1:27pm
appkit-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 1:27pm
appkit-gallery	✅ Ready (Inspect)	Visit Preview		Aug 1, 2025 1:27pm
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 1:27pm

11 Skipped Deployments

Name	Status	Preview	Updated (UTC)
appkit-basic-ep	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-basic-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-basic-sign-client-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-basic-up-example	⬜️ Ignored (Inspect)	Visit Preview	Aug 1, 2025 1:27pm
appkit-ethers5-bera	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-nansen-demo	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-vue-solana	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
appkit-wagmi-cdn-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
ethereum-provider-wagmi-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
next-wagmi-solana-bitcoin-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm
vue-wagmi-example	⬜️ Ignored (Inspect)		Aug 1, 2025 1:27pm

github-actions · 2025-05-17T21:32:45Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	77%	28883 / 37507
🔵	Statements	77%	28883 / 37507
🔵	Functions	68.41%	2430 / 3552
🔵	Branches	84.12%	5916 / 7032

File Coverage

No changed files found.

Generated in workflow #12529 for commit 8ac64a1 by the Vitest Coverage Report Action

…r tests Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

…ller-error-tests

enesozturk · 2025-06-02T05:50:01Z

@devin-ai-integration can you resolve merge conflict?

…749-APKT-2901-connection-controller-error-tests

…ller-error-tests

cursor · 2025-08-01T13:25:24Z

packages/controllers/tests/controllers/ConnectionController.test.ts

+        properties: { message: connectionError.message }
+      })
+
+      verifyEventSent(eventsSpy, 'CONNECT_ERROR')


Bug: Test Error Handling for External Connections

The test for ConnectionController.connectExternal's error handling manually calls EventsController.sendEvent. It should instead verify that ConnectionController.connectExternal internally sends the CONNECT_ERROR event upon failure.

test(controllers): Add comprehensive error handling tests for Connect…

695cae0

…ionController (APKT-2901) Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

devin-ai-integration bot requested a review from arein May 17, 2025 21:27

devin-ai-integration bot assigned arein May 17, 2025

vercel bot deployed to Preview – appkit-demo May 17, 2025 21:29 View deployment

vercel bot deployed to Preview – appkit-laboratory May 17, 2025 21:29 View deployment

fix(controllers): Add missing cosmos namespace to ConnectionControlle…

c3d6c37

…r tests Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

vercel bot deployed to Preview – appkit-demo May 17, 2025 21:44 View deployment

vercel bot deployed to Preview – appkit-laboratory May 17, 2025 21:46 View deployment

style: Fix prettier issues in ConnectionController.test.ts

94f1fe9

Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

vercel bot deployed to Preview – appkit-demo May 17, 2025 22:02 View deployment

vercel bot deployed to Preview – appkit-laboratory May 17, 2025 22:04 View deployment

fix: prettier

f9bf733

Co-Authored-By: derek@reown.com <alexanderderekrein@gmail.com>

vercel bot deployed to Preview – appkit-demo May 17, 2025 22:14 View deployment

vercel bot deployed to Preview – appkit-laboratory May 17, 2025 22:16 View deployment

Merge branch 'main' into devin/1747511749-APKT-2901-connection-contro…

10c8138

…ller-error-tests

vercel bot deployed to Preview – appkit-demo May 18, 2025 11:24 View deployment

vercel bot deployed to Preview – appkit-laboratory May 18, 2025 11:25 View deployment

tomiir enabled auto-merge May 22, 2025 07:33

tomiir approved these changes May 22, 2025

View reviewed changes

tomiir added this pull request to the merge queue May 22, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 22, 2025

Merge branch 'main' of github.com:reown-com/appkit into devin/1747511…

8ac64a1

…749-APKT-2901-connection-controller-error-tests

vercel bot deployed to Preview – appkit-basic-html June 10, 2025 11:06 View deployment

vercel bot deployed to Preview – appkit-demo June 10, 2025 11:06 View deployment

vercel bot deployed to Preview – appkit-laboratory June 10, 2025 11:10 View deployment

Merge branch 'main' into devin/1747511749-APKT-2901-connection-contro…

578fb3c

…ller-error-tests

vercel bot deployed to Preview – appkit-basic-html August 1, 2025 13:24 View deployment

vercel bot deployed to Preview – appkit-gallery August 1, 2025 13:24 View deployment

vercel bot deployed to Preview – appkit-demo August 1, 2025 13:24 View deployment

cursor bot reviewed Aug 1, 2025

View reviewed changes

vercel bot deployed to Preview – appkit-laboratory August 1, 2025 13:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(controllers): Add comprehensive error handling tests for ConnectionController (APKT-2901) #4364

test(controllers): Add comprehensive error handling tests for ConnectionController (APKT-2901) #4364

Uh oh!

devin-ai-integration bot commented May 17, 2025

Uh oh!

linear bot commented May 17, 2025

Uh oh!

changeset-bot bot commented May 17, 2025 •

edited

Loading

Uh oh!

devin-ai-integration bot commented May 17, 2025

Uh oh!

vercel bot commented May 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

enesozturk commented Jun 2, 2025

Uh oh!

cursor bot Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

test(controllers): Add comprehensive error handling tests for ConnectionController (APKT-2901) #4364

Are you sure you want to change the base?

test(controllers): Add comprehensive error handling tests for ConnectionController (APKT-2901) #4364

Uh oh!

Conversation

devin-ai-integration bot commented May 17, 2025

Add comprehensive error handling tests for ConnectionController (APKT-2901)

Description

Implementation Details

Ticket

Link to Devin run

Requested by

Uh oh!

linear bot commented May 17, 2025

Uh oh!

changeset-bot bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

devin-ai-integration bot commented May 17, 2025

🤖 Devin AI Engineer

Uh oh!

vercel bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

enesozturk commented Jun 2, 2025

Uh oh!

cursor bot Aug 1, 2025

Choose a reason for hiding this comment

Bug: Test Error Handling for External Connections

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented May 17, 2025 •

edited

Loading

vercel bot commented May 17, 2025 •

edited

Loading

github-actions bot commented May 17, 2025 •

edited

Loading