You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wagmi is getting the chain object with wrong parameters and finding the CAIP id from the network object. Passing the right Wagmi chain object to chain and removing chainId parameter (Viem doesn't have chainId param, see docs).
Type of change
Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link
Note
Update sendTransaction to pass the resolved Wagmi chain object rather than chainId.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The wagmiChain variable can be undefined if the current chainId doesn't match any chain in this.wagmiChains. This occurs when find returns no match, potentially causing transaction failures or unexpected behavior when passed to prepareTransactionRequest and wagmiSendTransaction. The previous implementation passed chainId directly, which was more reliable.
@reown/appkit - Main Entry
Size limit: 80 kB
Size: 73.89 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 442 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit/react
Size limit: 230 kB
Size: 227.32 kB with all dependencies, minified and gzipped
Loading time: 4.5 s on slow 3G
Running time: 1.3 s on Snapdragon 410
Total time: 5.7 s
@reown/appkit/vue
Size limit: 80 kB
Size: 73.89 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 422 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit-scaffold-ui
Size limit: 220 kB
Size: 208.03 kB with all dependencies, minified and gzipped
Loading time: 4.1 s on slow 3G
Running time: 613 ms on Snapdragon 410
Total time: 4.7 s
@reown/appkit-ui
Size limit: 500 kB
Size: 13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms on slow 3G
Running time: 80 ms on Snapdragon 410
Total time: 337 ms
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tomiir
deleted the
enes/apkt-4201-wagmiswaps-are-not-working-throws-transaction-error-message
branch
Description
Similar to this: #5317
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Update
sendTransactionto pass the resolved Wagmichainobject rather thanchainId.packages/adapters/wagmi/src/client.ts):sendTransaction: resolve current chain viathis.wagmiChainsand pass aschain, removingchainIdfrom tx params.Written by Cursor Bugbot for commit 5fcde32. This will update automatically on new commits. Configure here.