-
Notifications
You must be signed in to change notification settings - Fork 50
chore: upload builds to bucket #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances the Android and iOS release workflows by adding build artifact traceability, AWS S3 upload capabilities, and project-type differentiation. The changes improve the CI/CD pipeline with better build management and storage.
- Introduced a required
project-typeparameter to distinguish between wallet and dapp projects - Added AWS S3 upload functionality for build artifacts with proper credential configuration
- Enhanced release notes and artifact naming to include branch information and project type for better traceability
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/release-android-base.yaml |
Added project-type parameter, AWS credentials, S3 upload, and enhanced Firebase release notes |
.github/workflows/release-ios-base.yaml |
Added project-type parameter, AWS credentials, S3 upload, and improved caching with branch awareness |
fastlane/Fastfile |
Updated iOS build output naming and TestFlight changelog to include project type and branch |
| Release workflow files | Added project-type parameter to all wallet and dapp workflow configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request updates the Android and iOS release workflows to improve build traceability, add S3 upload support, and introduce a new required
project-typeparameter. The workflows now differentiate between wallet and dapp projects, include branch information in release notes and artifact names, and upload release artifacts to AWS S3 for both platforms. Additionally, caching strategies have been enhanced to be branch-aware, and AWS credentials are now configured within the workflows.Workflow enhancements and new parameters:
project-typeinput (wallet/dapp) to all release workflows and propagated its use throughout job definitions and Fastlane scripts to distinguish between project types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Artifact upload and AWS integration:
aws-account-idinput. Artifacts are named and stored by project type and release type. [1] [2] [3] [4]Release note and artifact naming improvements:
project-type,release-type, and the branch name for better traceability in both Firebase distribution and TestFlight uploads. [1] [2]Caching improvements:
Permissions updates:
id-token: writepermission to workflows to support secure authentication for AWS credential configuration. [1] [2]