fix: resolve Dependabot security vulnerabilities#470
Conversation
Bump hono 4.12.7→4.12.12, undici 6.24.0→6.24.1, minimatch 9.0.7→9.0.9, axios 1.13.5→1.15.0 across all 8 apps. Add missing overrides for hono (expo-wallet), elliptic and @xmldom/xmldom (W3MWagmi), undici and @xmldom/xmldom (W3MEthers5). Update addressable gem 2.8.7→2.9.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ride Upgrade picomatch 2.3.2→4.0.4 to fix POSIX Character Classes vulnerability. Remove brace-expansion 5.0.5 override from all 8 apps — v5 is ESM-only and breaks React Native codegen during pod install. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 4m 22s —— View job PR Review: fix/dependabot-alerts
|
There was a problem hiding this comment.
Pull request overview
Updates dependency override/resolution pins across multiple apps to address Dependabot-reported security vulnerabilities, while avoiding the ESM-only brace-expansion@5 override that breaks React Native codegen / pod install.
Changes:
- Bump pinned transitive dependencies (e.g.,
hono,undici,minimatch,picomatch,axios) to patched versions across affected apps. - Remove the ESM-only
brace-expansion@5.0.5override and allow compatible CJSbrace-expansion@2.xwhere required by updatedminimatch. - Update Ruby gem
addressableto2.9.0inGemfile.lock.
Reviewed changes
Copilot reviewed 8 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wallets/rn_cli_wallet/package.json | Updates Yarn resolutions pins (axios/minimatch/picomatch/undici) and removes brace-expansion@5 override. |
| wallets/rn_cli_wallet/yarn.lock | Lockfile updates reflecting bumped dependencies (axios → 1.15.0, minimatch → 9.0.9, picomatch → 4.0.4, etc.). |
| wallets/expo-wallet/package.json | Updates npm overrides pins; adds missing hono override and removes brace-expansion@5. |
| wallets/expo-wallet/package-lock.json | Lockfile updates for minimatch/picomatch/undici and removal of brace-expansion@5 install. |
| dapps/W3MWagmi/package.json | Updates Yarn resolutions pins; adds elliptic + @xmldom/xmldom pins and bumps hono/undici/minimatch/picomatch. |
| dapps/W3MWagmi/yarn.lock | Lockfile updates for bumped dependencies and @xmldom/xmldom consolidation to 0.8.12. |
| dapps/W3MEthers/package.json | Updates Yarn resolutions pins; removes brace-expansion@5 override and bumps undici/minimatch/picomatch. |
| dapps/W3MEthers/yarn.lock | Lockfile updates reflecting bumped minimatch/picomatch/undici and CJS brace-expansion dependency graph. |
| dapps/W3MEthers5/package.json | Updates Yarn resolutions pins; adds missing undici + @xmldom/xmldom overrides and bumps minimatch/picomatch. |
| dapps/W3MEthers5/yarn.lock | Lockfile updates for undici@6.24.1, @xmldom/xmldom@0.8.12, and related transitive changes. |
| dapps/pos-app/package.json | Updates npm overrides pins (hono/minimatch/picomatch/undici) and removes brace-expansion@5. |
| dapps/pos-app/package-lock.json | Lockfile updates reflecting minimatch/picomatch dependency changes and removal of brace-expansion@5. |
| dapps/poc-pos-app/package.json | Updates npm overrides pins (hono/undici/minimatch/picomatch) and removes brace-expansion@5. |
| dapps/poc-pos-app/package-lock.json | Lockfile updates reflecting minimatch/picomatch/undici bumps and removal of brace-expansion@5. |
| dapps/appkit-expo-wagmi/package.json | Updates npm overrides pins (hono/undici/minimatch/picomatch) and removes brace-expansion@5. |
| dapps/appkit-expo-wagmi/package-lock.json | Lockfile updates reflecting bumped pinned dependencies and dependency tree changes. |
| Gemfile.lock | Bumps addressable gem from 2.8.7 to 2.9.0 (and updates public_suffix upper bound). |
Files not reviewed (4)
- dapps/appkit-expo-wagmi/package-lock.json: Language not supported
- dapps/poc-pos-app/package-lock.json: Language not supported
- dapps/pos-app/package-lock.json: Language not supported
- wallets/expo-wallet/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -92,20 +92,19 @@ | |||
| "@vercel/node": { | |||
There was a problem hiding this comment.
🤖 Auto Review Issue: @vercel/node scoped undici override bypasses security fix
Severity: LOW
Category: security
Tool: Claude Auto Review
Context:
- Pattern:
"@vercel/node": { "undici": "5.29.0" }nested override exempts@vercel/node's transitive undici from the global6.24.1security fix applied elsewhere - Risk: undici 5.x has a history of CVEs; the scoped override means
@vercel/node's dep tree retains 5.x rather than being forced to 6.x - Impact: If a 5.x-affecting CVE is present, server-side Vercel routes in
pos-appremain exposed - Trigger: Only relevant if a specific undici 5.x CVE applies; may be intentional for
@vercel/nodeAPI compatibility
Recommendation: Document this tradeoff in the PR's "Not fixable" section, or verify that undici 5.29.0 is patched against all CVEs that triggered this PR. If @vercel/node accepts 6.x, remove the nested override:
// Remove the scoped override and rely on top-level "undici": "6.24.1"
// Test: npm install && vercel dev in pos-app
Summary
pod installvia RN codegen incompatibilityNot fixable (no patched version available)
ip2.0.1 — latest version, no fixelliptic6.6.1 — latest version, no fixbigint-buffer1.1.5 — abandoned packagebrace-expansion— safe CJS versions (2.x) are vulnerable; fixed versions (4.x/5.x) are ESM-only and break RN codegenTest plan
npm install/yarn installsucceeds in all 8 appspod installsucceeds in all 4 bare RN apps (rn_cli_wallet, W3MEthers, W3MEthers5, W3MWagmi)🤖 Generated with Claude Code