Appkit fix web wallet #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses fixes for the web wallet functionality in AppKit by disabling the disconnect operation in the modal view model, updating URL routing in the wallet detail view model for better browser handling, and refining the wallet opening logic in the session account presenter.
- Disable disconnect code in Web3ModalViewModel
- Add new browser navigation logic in WalletDetailViewModel with proper URL format handling
- Refactor openWallet method in SessionAccountPresenter to accept parameters for request ID and session topic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/ReownAppKit/Sheets/Web3ModalViewModel.swift | Comment out disconnect task code |
| Sources/ReownAppKit/Screens/ConnectWallet/WalletDetail/WalletDetailViewModel.swift | Implement formatted URL navigation for browser usage with fallback for mobile |
| Example/DApp/Modules/Sign/SessionAccount/SessionAccountPresenter.swift | Update wallet opening logic, introducing parameters for requestId and session topic |
Comments suppressed due to low confidence (1)
Example/DApp/Modules/Sign/SessionAccount/SessionAccountPresenter.swift:112
- The parameter name 'requstId' appears to be a typo; please correct it to 'requestId' for clarity and consistency.
private func openWallet(requstId: RPCID, topic: String) {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence