Readability improvement of Connection::connect#85
Merged
repejota merged 1 commit intorepejota:developfrom Apr 5, 2017
anthonysterling:fix-issue-57
Merged
Readability improvement of Connection::connect#85repejota merged 1 commit intorepejota:developfrom anthonysterling:fix-issue-57
repejota merged 1 commit intorepejota:developfrom
anthonysterling:fix-issue-57
Conversation
- Added a private isErrorResponse method to check if response is of -ERR - Created some Exception factory methods to centralise/standardise Exceptions and their messages Fixes #57
|
|
||
| $this->ping(); | ||
| $ping_response = $this->receive(); | ||
| if ($ping_response !== "PONG") { |
Contributor
Author
There was a problem hiding this comment.
I removed this as we could just check for -ERR and get the expected behaviour.
1 similar comment
Contributor
|
By reading the code look OK, @repejota what do you think ? I can test this PR tomorrow more in details |
Owner
|
Thanks!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57