Suppress warnings on stream_socket_client#87
Merged
repejota merged 1 commit intorepejota:developfrom Apr 5, 2017
Rentlio:develop
Merged
Suppress warnings on stream_socket_client#87repejota merged 1 commit intorepejota:developfrom Rentlio:develop
repejota merged 1 commit intorepejota:developfrom
Rentlio:develop
Conversation
…ost or port. For example when nats server is down.
2 similar comments
Owner
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling stream_socket_client and gnatsd is not running, stream_socket_client throws warnings , not exceptions. So I have added void error handler that suppresses just this call end then pops out of an error handler stack.
And if stream handle does not exist, now exception is thrown before trying to call stream_set_timeout.
Tests are added by using hopefully non used port in travis.