Fixes random id generator for php 7.1+#89
Merged
repejota merged 3 commits intorepejota:developfrom Apr 5, 2017
Merged
Conversation
Contributor
Author
|
@repejota Anything you'd like me to change? |
dfeyer
suggested changes
Mar 1, 2017
Contributor
dfeyer
left a comment
dfeyer
left a comment
There was a problem hiding this comment.
Need to be fixed upstream, check https://github.com/ircmaxell/RandomLib/pulls?utf8=%E2%9C%93&q=is%3Apr%207.1 ... there is some discussions
Contributor
Author
|
If he's going to patch it then great. There wasn't much movement from him at the time I ran into this: ircmaxell/RandomLib#55 |
Contributor
Author
|
As much as it's nice to hope for an upstream fix for this I would think quite important soon to GTM as 7.1 is getting adopted more and more. |
Owner
|
🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.