TASK: More solid method to send payload to the socket#90
Merged
repejota merged 2 commits intorepejota:developfrom Apr 5, 2017
Merged
TASK: More solid method to send payload to the socket#90repejota merged 2 commits intorepejota:developfrom
repejota merged 2 commits intorepejota:developfrom
Conversation
I can happens that fwrite does exit but without sending the full payload, or it can also happen that the pipe is closed or broken. With the change the logic a bit more complex but retry write operation. We need to silently ignore (@fwrite) notice/warnings from fwrite to be able to catch the broken pipe error (without the silent operator fwrite, will return a notice, and depending on the user php configuration, error handler, level, ... this can be converted to an exception or something that will skip the retry logic and our exception)
1 similar comment
Owner
|
Thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can happens that fwrite does exit but without sending the full payload, or it can also happen that the pipe is closed or broken. With the change the logic a bit more complex but retry write operation. We need to silently ignore (@fwrite) notice/warnings from fwrite to be able to catch the broken pipe error (without the silent operator fwrite, will return a notice, and depending on the user php configuration, error handler, level, ... this can be converted to an exception or something that will skip the retry logic and our exception)