Skip to content

TASK: Close should check if the current socket is null#91

Merged
repejota merged 2 commits intorepejota:developfrom
dfeyer:patch-3
Apr 5, 2017
Merged

TASK: Close should check if the current socket is null#91
repejota merged 2 commits intorepejota:developfrom
dfeyer:patch-3

Conversation

@dfeyer
Copy link
Copy Markdown
Contributor

@dfeyer dfeyer commented Mar 2, 2017

If we call close (by ex. during a reconnect) but the streamSocket is null, we generate useless error for the user.

If we call close (by ex. during a reconnect) but the streamSocket is null, we generate useless error for the user.
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 2, 2017

Coverage Status

Coverage increased (+0.3%) to 88.525% when pulling 33a7e17 on dfeyer:patch-3 into d1fc1da on repejota:develop.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 5, 2017

Coverage Status

Coverage decreased (-1.1%) to 88.442% when pulling b089351 on dfeyer:patch-3 into 82a139b on repejota:develop.

3 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.1%) to 88.442% when pulling b089351 on dfeyer:patch-3 into 82a139b on repejota:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.1%) to 88.442% when pulling b089351 on dfeyer:patch-3 into 82a139b on repejota:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.1%) to 88.442% when pulling b089351 on dfeyer:patch-3 into 82a139b on repejota:develop.

@repejota repejota merged commit 614051f into repejota:develop Apr 5, 2017
@repejota
Copy link
Copy Markdown
Owner

repejota commented Apr 5, 2017

Thanks! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants