fix: enable macOS framework linking by setting ObjC language mode#23
Merged
repentsinner merged 1 commit intomainfrom Feb 26, 2026
Merged
fix: enable macOS framework linking by setting ObjC language mode#23repentsinner merged 1 commit intomainfrom
repentsinner merged 1 commit intomainfrom
Conversation
native_toolchain_c only passes -framework flags to clang when the language is objectiveC. Without this, IOKit/CoreFoundation/AppKit frameworks were silently dropped, causing undefined symbol errors on macOS. Also fix hidOpen test to use 0xFFFF/0xFFFF instead of 0/0, since VID/PID 0 is a wildcard that matches real devices on macOS.
repentsinner
force-pushed
the
fix/macos-framework-linking
branch
from
4a4768a to
35b38d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native_toolchain_c only passes -framework flags to clang when the language is objectiveC. Without this, IOKit/CoreFoundation/AppKit frameworks were silently dropped, causing undefined symbol errors on macOS. Also fix hidOpen test to use 0xFFFF/0xFFFF instead of 0/0, since VID/PID 0 is a wildcard that matches real devices on macOS.