Skip to content

Borderless UI follow up fixes#4314

Merged
jasonLaster merged 2 commits intoreplayio:masterfrom
jaril:1104-ui-polish
Nov 5, 2021
Merged

Borderless UI follow up fixes#4314
jasonLaster merged 2 commits intoreplayio:masterfrom
jaril:1104-ui-polish

Conversation

@jaril
Copy link
Copy Markdown
Contributor

@jaril jaril commented Nov 5, 2021

Fix #4309.

  1. 8px vertical border between the video and the sidepanels
    image
  2. Made the share button height ~32px. This isn't quite the same as 34px as the view toggle, but because of the gray border the view toggle looks a tad smaller than it actually does and this ends up looking 👌. Thoughts welcome.
    image
  3. Can't reproduce this one.
  4. Made the padding around the toolbar 8px.
    image
  5. Made an executive decision on the border underneath the header and made it thinner so it's more consistent with the other gaps. Otherwise it ended up looking too thick.
    image

@jonbell-lot23 I'll leave the decision re: #2 and #5 to you. Let me know what you think!

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/recordreplay/devtools/FVK8RDDM62U6wQkdf1ywyNzVcsKK
✅ Preview: https://devtools-git-fork-jaril-1104-ui-polish-recordreplay.vercel.app

@jonbell-lot23
Copy link
Copy Markdown
Contributor

Love 'em, thanks!

@jasonLaster
Copy link
Copy Markdown
Contributor

I spy a border 😉

Screen Shot 2021-11-04 at 10 56 47 PM

Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Love these tweaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breathe UI tweaks

3 participants