Skip to content

Add polish to testsuites (attempt #2)#9935

Merged
jonbell-lot23 merged 7 commits intomainfrom
2023-11-27-testsuite-polish-2
Nov 28, 2023
Merged

Add polish to testsuites (attempt #2)#9935
jonbell-lot23 merged 7 commits intomainfrom
2023-11-27-testsuite-polish-2

Conversation

@jonbell-lot23
Copy link
Copy Markdown
Contributor

Addressed these issues from this ticket:

Fixed icon alignment
Adjusted gutters
Added a hover state
Height of headers and rows match now
Added a bottom border
Fixed left padding on left nav

Old:
image

New:
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 6:26am

@jonbell-lot23
Copy link
Copy Markdown
Contributor Author

Note for @ryanjduffy because things have gotten backed up with the GitHub outage:

  1. First I'm waiting for this revert to be ready for merge
  2. I'm also waiting for a preview link here (things seem to look good on localhost)
  3. Once I can confirm 1 and 2 are good, then this will be ready for review

@replay-io
Copy link
Copy Markdown

replay-io Bot commented Nov 27, 2023

Snapshot Tests

StatusIn Progress ↗︎
Commit0904010
Results
⚠️ 1 Flaky
80 Passed

null

StatusComplete ↗︎
Commit67465f8
Results
⚠️ 3 Flaky
87 Passed

@replay-delta
Copy link
Copy Markdown

replay-delta Bot commented Nov 27, 2023

@jonbell-lot23
Copy link
Copy Markdown
Contributor Author

Ok @ryanjduffy , this looks good to me. Ready for review!

Comment thread src/ui/components/Timeline/Timeline.css Outdated
Comment thread src/ui/components/Library/Library.module.css Outdated
Comment thread src/ui/components/Library/Library.module.css

.replayListTitle {
padding: 0.5rem 1rem 0.08rem;
font-size: 1.125rem;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another example of a bizarre size increment.

Copy link
Copy Markdown
Contributor Author

@jonbell-lot23 jonbell-lot23 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous resolved comments with Ryan. These are a natural side effect of polishing a design to make things line up. It's not a flaw in the design, and it will continue to happen as I improve our layouts.

@bvaughn bvaughn deleted the 2023-11-27-testsuite-polish-2 branch November 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants