Add polish to testsuites (attempt #2)#9935
Merged
jonbell-lot23 merged 7 commits intomainfrom Nov 28, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Note for @ryanjduffy because things have gotten backed up with the GitHub outage:
|
Contributor
Author
|
Ok @ryanjduffy , this looks good to me. Ready for review! |
ryanjduffy
approved these changes
Nov 28, 2023
bvaughn
reviewed
Nov 28, 2023
|
|
||
| .replayListTitle { | ||
| padding: 0.5rem 1rem 0.08rem; | ||
| font-size: 1.125rem; |
Contributor
There was a problem hiding this comment.
This is another example of a bizarre size increment.
Contributor
Author
There was a problem hiding this comment.
See previous resolved comments with Ryan. These are a natural side effect of polishing a design to make things line up. It's not a flaw in the design, and it will continue to happen as I improve our layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed these issues from this ticket:
Fixed icon alignment
Adjusted gutters
Added a hover state
Height of headers and rows match now
Added a bottom border
Fixed left padding on left nav
Old:

New:
