fix: initialize pulsar client before creating subscription #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation attempted to create a subscription without initializing the pulsar client first, resulting in a nil pointer error when calling p.client.Subscribe(). This fix ensures the client is properly initialized before any subscription operations. Changes: - Add pulsar.NewClient() call before Subscribe() in PulsarConsumerSource.Capture - Mirror the initialization pattern used in PulsarReaderSource.Capture Fixes nil pointer dereference when creating pulsar consumer subscriptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
KennyChenFight
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PulsarConsumerSource.Capturemethod was attempting to callp.client.Subscribe()without initializingp.clientfirstpulsar.NewClient()call to match the initialization pattern used inPulsarReaderSource.CaptureChanges
pkg/source/pulsar.go:195-198: Initialize pulsar client before creating consumer subscriptionImpact
This resolves a critical bug where the pulsar consumer would crash with a nil pointer error when attempting to create subscriptions. The fix ensures proper client initialization following the same pattern as the reader source implementation.
Test plan
🤖 Generated with Claude Code