Revert "Handle predictors with deferred annotations (#1772)"#1918
Merged
technillogue merged 1 commit intomainfrom Sep 13, 2024
Merged
Revert "Handle predictors with deferred annotations (#1772)"#1918technillogue merged 1 commit intomainfrom
technillogue merged 1 commit intomainfrom
Conversation
technillogue
force-pushed
the
syl/revert-deferred-annotations
branch
from
49fc5a5 to
163777b
Compare
This reverts commit 05900a7. This is needed to avoid breaking predictors that rely on __signature__ or partial.
technillogue
force-pushed
the
syl/revert-deferred-annotations
branch
from
163777b to
cc545ae
Compare
mattt
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 05900a7.
This is needed to avoid breaking predictors that rely on signature or partial.
I'm suggesting merging this ahead of #1895 to unblock certain language models that have been broken