Use tmp image name in intermediate build step #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilSinha1
changed the title
NikhilSinha1
changed the title
added 2 commits
January 27, 2026 12:12
meatballhat-cf
approved these changes
Jan 27, 2026
Contributor
meatballhat-cf
left a comment
meatballhat-cf
left a comment
There was a problem hiding this comment.
Admittedly a bit icky with the temporary name, but at least it's cog-flavored so folks will know where to come for help.
meatballhat-cf
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Orbstack does not like the
r8.im/...@sha256:...format, so we cannot do the change the original way we thought we would. Instead, we should try to name the intermediary image a temporary name that must not include a "hostname" part. We will then tag it and push it with the correct name after completing the final build, and remove the temporary image.Test Plan
We ran the
./script/test-e2e-rebuildscript on both a machine set up with docker desktop and a machine set up with orbstack. It succeeded on both machines, which gives us confidence that this is the right approach.