fix: docs deploy workflow uses Go 1.23, can't parse go.mod tool directive#2924
Merged
michaeldwan merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: docs deploy workflow uses Go 1.23, can't parse go.mod tool directive#2924michaeldwan merged 1 commit intomainfrom
michaeldwan merged 1 commit intomainfrom
Conversation
…tive go.mod uses the tool directive (Go 1.24+) but the docs workflow hardcoded go-version: '1.23'. Use go-version-file: go.mod like every other workflow in the repo.
Contributor
|
LGTM |
markphelps
added a commit
that referenced
this pull request
Apr 13, 2026
…to test-harness-go * 'test-harness-go' of https://github.com/replicate/cog: fix: run async setup() on the same event loop as predict() (#2927) fix: support dict and list[dict] as predictor input types (#2928) fix: docs deploy workflow uses Go 1.23, can't parse go.mod tool directive (#2924) fix: await async def setup() coroutine instead of silently dropping it (#2921) chore(deps): bump actions/setup-go from 5 to 6 (#2767) fix: stub generation fails locally and produces unformatted output (#2920)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs deploy workflow hardcodes
go-version: '1.23', butgo.moduses thetooldirective which requires Go 1.24+. The "Generate CLI docs" step fails immediately:Switch to
go-version-file: go.mod-- consistent with every other workflow in the repo.