fix: support typing_extensions TypedDict at runtime#2983
Merged
Conversation
Contributor
|
LGTM |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| if is_typeddict_ext(tpe): | ||
| return True | ||
| except ImportError: |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| if is_typeddict_ext(tpe): | ||
| return True | ||
| except ImportError: | ||
| pass |
Contributor
There was a problem hiding this comment.
Empty except clause without explanatory comment. Please add a comment explaining that typing_extensions is optional and the function falls back to typing.is_typeddict below.
Suggested change
| pass | |
| except ImportError: | |
| # typing_extensions is optional; fall back to typing.is_typeddict below | |
| pass |
Contributor
|
Posted a review on PR #2983. The changes add proper runtime support for |
michaeldwan
previously approved these changes
May 1, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Contributor
|
fatal: couldn't find remote ref fix-typing-extensions-typeddict-runtime |
Contributor
|
@markphelps Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing_extensions.is_typeddictwhen detecting dict-like annotations in the legacy runtime schema path.typing_extensions.TypedDictinputs, including list/optional forms.typing_extensions.TypedDict.Tests
.venv/bin/python -m pytest python/tests/test_adt.py -qmise run lint:pythonFixes the runtime/legacy half of #2973 follow-up; third-party TypedDicts in the static Go parser remain a separate issue.